Skip to content

feat(hosted): run hosted upload from the app config (#140) - #304

Merged
rowkav09 merged 1 commit into
mainfrom
feat/hosted-app-wiring
Sep 23, 2026
Merged

rowkav09 merged 1 commit into
mainfrom
feat/hosted-app-wiring

Conversation

@rowkav09

Copy link
Copy Markdown
Member

What changed

Last app-side slice of the #140 desktop uploader: the running app can now push to the hosted card service.

  • config.json gets an optional hosted: { enabled, url? }. Off by default, and absent from configs that don't set it, so existing installs are unchanged. url must be HTTPS (defaults to https://nowplaying-hosted.vercel.app). Unknown keys make the config invalid, same as the rest of the file.
  • startHostedFromConfig starts the loop from feat(hosted): credential store and polling loop for hosted uploads (#140) #297 with the uploader from feat(hosted): desktop uploader client for hosted cards (#140) #295. With no credential store it reports no_credentials instead of starting.
  • startAppFromConfig takes hostedCredentials; the Windows entry passes the Credential Manager store. It returns hosted status and hostedCardUrl(), and stops the loop on close.
  • The status snapshot gains hosted: { enabled, state, lastSuccessAt, error } (allow-listed words only, no tokens or IDs).
  • Hosted upload runs apart from Discord: an offline host never touches presence.

The settings toggle and card link UI are tracked in #290 (web UI lane).

Checks

  • Tests pass locally
  • No secrets, tokens, server URLs, or personal media data are committed
  • Docs or tests were updated when behavior changed
  • The change is scoped to one roadmap issue

Issue

Part of #140

@rowkav09 rowkav09 added the mira-paused Pause automatic Mira reviews on this pull request label Sep 23, 2026
@github-project-automation github-project-automation Bot moved this to Backlog in nowplaying Sep 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

/mira pause

@codecov

codecov Bot commented Sep 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.15385% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/app-config.js 93.33% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@rowkav09
rowkav09 force-pushed the feat/hosted-app-wiring branch from ebff489 to 182af20 Compare September 23, 2026 22:59
@rowkav09
rowkav09 force-pushed the feat/hosted-app-wiring branch from 182af20 to 13c2606 Compare September 23, 2026 23:02
@rowkav09
rowkav09 merged commit 6a69821 into main Sep 23, 2026
13 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in nowplaying Sep 23, 2026
This was referenced Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mira-paused Pause automatic Mira reviews on this pull request size:M

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant